chore: add librarian integration for google-cloud-spanner#16548
Merged
chore: add librarian integration for google-cloud-spanner#16548
Conversation
parthea
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request unblocks the generation of the google-cloud-spanner library and introduces extensive customizations, including MetricsInterceptor integration, gRPC keepalive settings, and updated dependencies like OpenTelemetry. It also overhauls the documentation and noxfile.py test automation. Feedback identifies a critical missing logging import in docs/conf.py, typos in example email addresses, trailing whitespace in the integration YAML, and an incomplete linting session that should include ruff check.
.librarian/generator-input/client-post-processing/spanner-integration.yaml
Outdated
Show resolved
Hide resolved
.librarian/generator-input/client-post-processing/spanner-integration.yaml
Outdated
Show resolved
Hide resolved
.librarian/generator-input/client-post-processing/spanner-integration.yaml
Outdated
Show resolved
Hide resolved
.librarian/generator-input/client-post-processing/spanner-integration.yaml
Show resolved
Hide resolved
parthea
force-pushed
the
unblock-generate-spanner
branch
from
7d376a9 to
25456a7
Compare
parthea
force-pushed
the
unblock-generate-spanner
branch
from
25456a7 to
dff3b0d
Compare
ohmayr
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16490